Skip to content

Display gender pronouns in user popover

📖 What does this MR do?

Related to #333042 (closed)

In !63221 (merged) we added support for displaying gender pronouns on your profile. This MR adds support for displaying the gender pronouns on the user popover that is shown when hovering over a user's name in issues and MRs. In the process of adding gender pronouns to the popover this MR also adjusts the styling of the "(Busy)" text. This adjustment is so that it looks better next to the gender pronouns. This change to the "(Busy)" text affects the MR assignee as the component that was changed is shared between assignees and user popover.

💻 Local testing

  1. Navigate to /-/profile and set your pronouns
  2. Navigate to an issue or MR that you have commented on
  3. Hover over your name

📷 Screenshots

View Before After
User popover - pronouns set Screen_Shot_2021-06-15_at_3.15.13_PM Screen_Shot_2021-06-15_at_2.40.45_PM
User popover - "Busy" and pronouns set Screen_Shot_2021-06-15_at_3.14.40_PM Screen_Shot_2021-06-15_at_2.40.16_PM
User popover - "Busy" and pronouns not set Screen_Shot_2021-06-15_at_3.15.13_PM Screen_Shot_2021-06-15_at_2.44.04_PM
MR assignee Screen_Shot_2021-06-15_at_3.18.25_PM Screen_Shot_2021-06-15_at_3.26.14_PM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading