Skip to content

Updating left side panel templates in preparation for the styles refactoring

Denys Mishunov requested to merge 322680-legacy-templates-markup into master

What does this MR do?

The MR prepares the templates that are not yet covered by the refactoring but should still be styled according to the new design.

The main change points:

  • adding has-sub-items class to the top-level navigation items in case there are sub-items
  • wrapping the fly-out menu titles into feature flag check and supply alternative markup behind the feature flag without a link

To smoke test in the browser, you will need to either enable or disable the feature flag:

  gitlab git:(322680-contextual-header-styling)  rails c
...
[1] pry(main)> Feature.enable(:sidebar_refactor, User.find_by_username('root'))

Screenshots (strongly suggested)

master This MR
With the FF ON Screenshot_2021-06-09_at_20.29.29 Screenshot_2021-06-09_at_20.25.49
With the FF OFF Screenshot_2021-06-09_at_20.30.31 Screenshot_2021-06-09_at_20.19.56

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322680 (closed)

Edited by Denys Mishunov

Merge request reports

Loading