Hide hidden issues from issues list
What does this MR do?
Epic: &5741
Issue: #327355 (closed)
Malicious actors create many issues in public projects/groups for spam. We need a way to be able to hide their issues until they can be reviewed and deemed safe. So we've introduced the ability for admins to ban users, which blocks the user and hides their contributions.
This MR hides issues created by banned users from non-admins. Admin users can still see the hidden issues so they can review the issues' contents.
Follow up issues for UI polish: #332408 (closed), https://gitlab.com/gitlab-org/gitlab/-/issues/332409
Remember to rebase after !63676 (closed)
Screenshots (strongly suggested)
When admin:
Project open issue count includes confidential and hidden issues. Hidden issues are indicated by a spam icon and with a tooltip that lets the admin know why the issue is hidden. Admin can access hidden issues to review their content.
Group issue count includes confidential and hidden issues.
When group reporter:
Project open issue count includes confidential issues but not hidden issues. Hidden issue does not appear in issues list, and reporter cannot access hidden issue even when following a link.
Group issue count includes confidential issues but not hidden issues.
When non-member:
Project open issue count does not include confidential or hidden issues. Hidden issue does not appear in issues list, and non-member cannot access hidden issue even when following a link.
Group issue count does not include confidential or hidden issues.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team