Skip to content

Pajamas-compliant alert HAML template

What does this MR do?

This updates the shared alert HAML template as follows:

  • Titles are now wrapped in H4's instead of DIVs.
  • Dismiss button now...
    • ...follows the design specs by using tertiary GlButton styles.
    • ...can be hidden by setting the dismissible parameter to false (true by default).
  • Alerts content width now uses GitLab UI's width constraint when using a fluid layout.
  • With a fixed layout, alerts use GitLab's content classes so that the alert's content width matches that of the primary content. This can be opted-out by setting the is_contained option to true, which should be done when rendering an alert inside the primary content.

Additionally:

  • Some info buttons have been migrated to the confirm variant (no visual change).
  • The ee/app/views/shared/_new_user_signups_cap_reached_alert.html.haml view has been migrated to use the shared alert template (re #325409 (closed)).

Screenshots (strongly suggested)

Fluid layout

Before After
Screen_Shot_2021-06-11_at_7.16.39_AM after

Fixed layout

Before After
Screen_Shot_2021-06-11_at_7.17.06_AM after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading