Convert SAML module to class
What does this MR do?
Convert SAML module to class.
When running the test locally, the following failures were detected.
bundle exec spring rspec -- ee/spec/features/groups/saml_providers_spec.rb
<SNIP>
Failure/Error: return yield unless new(admin).admin_mode?
TypeError:
wrong argument type Class (expected Module)
# ./ee/app/services/group_saml/saml_provider/update_service.rb:6:in `include'
# ./ee/app/services/group_saml/saml_provider/update_service.rb:6:in `<class:UpdateService>'
# ./ee/app/services/group_saml/saml_provider/update_service.rb:5:in `<module:SamlProvider>'
# ./ee/app/services/group_saml/saml_provider/update_service.rb:4:in `<module:GroupSaml>'
# ./ee/app/services/group_saml/saml_provider/update_service.rb:3:in `<main>'
The BaseService
module also has an initialize
method which signals this should have been a class instead.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Tan Le