Skip to content

Remove managed-cluster alert code and deprecation feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Tristan Read requested to merge tr-remove-alert-deprecation-feature-flag into master

What does this MR do?

The GitLab-managed Kuberenetes cluster alerts feature was removed by flipping the managed_alerts_deprecation feature flag to default-off in 14.1. This MR:

  • Removes the managed-cluster alerts disabled code.
  • Removes the :managed_alerts_deprecation feature flag.

Background:

  • In GitLab 14.0 and earlier there was a GitLab-managed-cluster feature, whereby GitLab would install and manage applications on a connected Kubernetes cluster.
  • This feature was deprecated in 14.0 and removed in 14.1.
  • This change meant the alerts feature for Metrics dashboards is no longer useable, so the UI was disabled behind a feature flag at the same time.

To test the changes:

  • Set up a kubernetes cluster, install Prometheus on to the cluster. Ensure that Prometheus is available from the GDK.
  • Connect Prometheus to the GitLab instance. Settings -> Integrations -> Prometheus.
  • Deploy at least one environment to the cluster.
  • View the metrics dashboard.

Issue: #331863 (closed)

Screenshots (strongly suggested)

None - no visual change.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports

Loading