Add unique validation to additional pack purchase_xid
What does this MR do?
In !62393 (merged) we added a new (currently unused) table for tracking CI Minute provisioning.
This table will primarily to be used for two things:
- tracking purchases of additional CI minutes
- managing the provisioning of those minutes (expiry, usage, etc)
The second point introduces a slight complexity, in that we discovered our self-managed customers may also be using the concept of CI minute limits / additional minutes, to prevent over-use on their own runners.
This means that we need to support both GitLab.com and self-managed instances, so the table was originally created with no unique constraints or indices.
This MR attempts to add a unique index solely for GitLab.com so that we can attempt to ensure that entries are unique scoped to namespace and purchase ID.
I've opted not to add a unique index for Gitlab.com only, as diverging the GL database away from SM seems high risk. Instead we'll just use a standard rails validation and accept the increased risk of duplicate entries due to race conditions (unlikely anyway, as it will not be used via a public API)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team