Skip to content

Take a more declarative path when using membership_actions concern

What does this MR do?

  • resolves the following...
  • There are 3 case statements in this concern that go something like when Namespace and when Project - there is simply no need for that since this concern is only used in project_members_controller.rb and group_members_controller.rb and we'd be better served by taking declarative paths as the answer of is this a group or project has already been answered by which of those controllers is being enacted....there is no need to ask the question yet again with a case/when statement.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333439

Edited by Doug Stull

Merge request reports

Loading