Skip to content

Reintroduce text on Pipeline Widget dropdown

Jannik Lehmann requested to merge jnnkl-download-dropdown-refactor into master

What does this MR do?

This MR fixes this Problem: !63957 (comment 600228361)

When: !63407 (merged) was merged the text on the Dropdown was removed not only from the Merge-Request Widget but from the Pipeline-Widget as well.

This MR reintroduces the text on Pipeline Widget dropdown, while not reintroducing it on the Merge-Request Widget.

Furthermore: additional tests have been added to make sure changes like that are caught earlier in the future.

Screenshots (strongly suggested)

MR Widget (no difference)

before after
Screenshot_2021-06-08_at_16.19.52 Screenshot_2021-06-08_at_16.19.52

Pipeline Widget

before after
Screenshot_2021-06-14_at_15.35.55 Screenshot_2021-06-14_at_15.31.53

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jannik Lehmann

Merge request reports

Loading