Skip to content

Update supported browser versions

Lukas Eipert requested to merge leipert-adjust-browser-versions into master

What does this MR do?

Make browserslist known as a frontend file

If we are adjusting browser versions, we want a full pipeline to see the effects (e.g. bundle size changes, etc.). Furthermore Danger should know about the browserslist file.

Ensure updating browsers forces babel to recompile

Given that we use @babel/preset-env transpiled files contain imports to core-js at the top of the file. babel-loader caches those transpiled files. If we bump the supported browser versions in .browserslistrc, we might need less imports of corejs modules. But as they are cached, we will retrieve those outdated files with the wrong imports causing unneccessary core-js modules to be imported.

Update supported browser versions

This increases supported browser versions to:

  • Google Chrome/Chromium: at least major version 84 because older versions have an annoying bug with Array.reduce: https://bugs.chromium.org/p/chromium/issues/detail?id=1049982
  • Microsoft Edge: at least majoy version 84 (dropping support for pre-Chromium Edge). (Same reasoning as with Chrome)
  • Mozilla Firefox: at least major version 78, as this is the latest ESR and it is used quite a lot.
  • Apple Safari: at least major version 13 (dropping support for Safari 12) because it is the second latest version of Safari

Changelog: changed

Update startup css

Due to our browser changes less vendor prefixes are needed, so we need to regenerate startup css files.

Update browser compatability data

It seems like the previous changes didn't yield the expecteded results and some polyfills were still included. By updating browser compatibility data we might be able to get newer information and hopefully less polyfills.

Increase assets cache key

Updating our supported browser versions is a major change to our assets. In order to ensure that there are no unintended side-effects, we update all caches.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading