Experiment Clean Up: make registrations_group_invite permanent [RUN ALL RSPEC] [RUN AS-IF-FOSS]
requested to merge 332987-experiment-clean-up-registrations_group_invite-group-invite-on-separate-page into master
What does this MR do?
- Commit to the experiment where the invites on registration to a group are on a separate page for
.com
. as per #332987 - Consolidate guard
before
method on registration flow controllers to the method check for.com
. - Cleanup errant code under
new
view for groups template forinvites
.
note
See !52371 (merged) for screenshots of the page being commited.
How to test in GDK
- Register as a new user on your GDK/GitLab instance in the browser
- Either click
Register now
on sign-in page, or sign out and visit this pagehttp://localhost:3000/users/sign_up
- Either click
- Create User, Group, and then the next page(before creating project) should be the group invites one we are adding.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #332987
Edited by Doug Stull