Add support for data-canonical-src in content editor links + add tests
What does this MR do?
This MR builds upon the work of !64032 (merged) (which is the target branch currently). Here's a description of what the original MR does:
When rendering Markdown using the various Markdown endpoints in the application, the URL specified in the Markdown source is transformed by the Markdown rendering pipeline for several purposes: security, resolving a URL for rendering, etc. The original URL, as stored in the Markdown source, is lost after this transformation.
This Merge Request preserves the original URL, as stored in the source, in the
data-canonical-src
attribute. The purpose is allowing the Content Editor to re-generate the image or link definition in the client when serializing the HTML back to Markdown.
This MR:
- Adds support for
data-canonical-src
in all links in content editor, and - Adds a
context
attribute to ourapi_markdown.yml
file, which allows you to define a context in which the markdown should be processed. For now we have four contexts: groups, projects, group wikis and project wikis. The output of the resulting markdown may be same (or similar), but keeping these contexts separate makes room for future tests where we add more cases like relative URLs, mentions, issue and MR references.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team