Skip to content

Add Running Container Scanning Max Size Limit

What does this MR do?

In scope of &3410 (closed) we are adding new report type: running_container_scanning. Since we are adding new file type to Job Artifacts (in !64211 (closed)), we need to satisfy all file types have corresponding limit file_type check: https://gitlab.com/gitlab-org/gitlab/-/jobs/1352262492. This MR adds new field to satisfy this check.

Migrations

⋊> ~/D/g/gitlab on 330713-add-running-container-scanning-size-liit ⨯ env VERBOSE=true bundle exec rake db:migrate:up VERSION=20210614142311
== 20210614142311 AddRunningContainerScanningMaxSizeToPlanLimits: migrating ===
-- add_column(:plan_limits, :ci_max_artifact_size_running_container_scanning, :integer, {:null=>false, :default=>150})
   -> 0.0061s
== 20210614142311 AddRunningContainerScanningMaxSizeToPlanLimits: migrated (0.0062s) 
⋊> ~/D/g/gitlab on 330713-add-running-container-scanning-size-liit  env VERBOSE=true bundle exec rake db:migrate:down VERSION=20210614142311
== 20210614142311 AddRunningContainerScanningMaxSizeToPlanLimits: reverting ===
-- remove_column(:plan_limits, :ci_max_artifact_size_running_container_scanning, :integer, {:null=>false, :default=>150})
   -> 0.0116s
== 20210614142311 AddRunningContainerScanningMaxSizeToPlanLimits: reverted (0.0160s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #330713 (closed)

Edited by Mayra Cabrera

Merge request reports

Loading