Skip to content

Resolve "Run UserRefreshFromReplicaWorker on the replica database"

What does this MR do?

The AuthorizedProjectUpdate::UserRefreshFromReplicaWorker runs project authorization refresh jobs for users. This class is specifically used as a safety-net along with newer project authorization approaches using specialized workers. An example is here.

The only place AuthorizedProjectUpdate::UserRefreshFromReplicaWorker is enqueued from is here

Since this worker runs always as a "safety-net" and with a 1 hour delay, it is a good candidate to be run on the replica database (as its class name rightly suggests 😄) and this MR is aimed at making this worker read the data from the replica database.

Internally, after this change, this worker:

  • will read the data of a user's project authorizations from the replica database.
  • Using AuthorizedProjectUpdate::FindRecordsDueForRefreshService.new(user).needs_refresh?, it will check in the replica database whether the user needs a project authorizations refresh.
  • If it does, it enqueues a new job using AuthorizedProjectUpdate::UserRefreshWithLowUrgencyWorker.perform_async(user.id) for this particular user (which would eventually read the data from the primary)

This is the same pattern we use in periodic project authorization jobs and it has been working well for us.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333219 (closed)

Edited by Manoj M J

Merge request reports

Loading