Skip to content

Resolve "Generic Vulnerability Report: `file-location` component does not render on pipeline-security view"

What does this MR do?

This fixes a bug that prevents the generic security report's file-location type to render on the pipeline's security view.

The issue is caused by data coming from the API in snake_case but the component expecting it to be in camelCase.

Screenshots (strongly suggested)

before after
Screen_Shot_2021-06-17_at_1.54.20_pm Screen_Shot_2021-06-17_at_1.58.20_pm

How do I test this locally?

  1. Create a new project
  2. Add new .gitlab-ci.yml file with the following content:
stages:
    - dast

dast:
  stage: dast 
  image: alpine:3.10.2
  script:
    - pwd
  artifacts:
    reports:
      dast: dast.json
  1. Add new dast.json file with contents from: $2136483
  2. Run pipeline and go to the pipeline's security tab, click on the vulnerability

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333894 (closed)

Edited by David Pisek

Merge request reports

Loading