Skip to content

Move to urlParamsToObject to url_utility.js and deprecate it

Miguel Rincon requested to merge 328845-move-urlParamsToObject-to-url-utils into master

What does this MR do?

This change moves urlParamsToObject and related functions to the url_utility file, this will help a single way to parse URL queries.

Why this change? In #328845 (closed) we agreed that we should have a single query string parser.

List of new deprecations:

$ grep "eslint-disable.*import/no-deprecated" -l -r $(git ls-files -m)
app/assets/javascripts/boards/stores/actions.js
app/assets/javascripts/boards/stores/boards_store.js
app/assets/javascripts/issues_list/components/issuables_list_app.vue
app/assets/javascripts/members/components/filter_sort/members_filtered_search_bar.vue
app/assets/javascripts/members/components/members_tabs.vue
app/assets/javascripts/projects/commits/components/author_select.vue
ee/app/assets/javascripts/analytics/code_review_analytics/filtered_search_code_review_analytics.js
ee/app/assets/javascripts/analytics/productivity_analytics/filtered_search_productivity_analytics.js
ee/app/assets/javascripts/boards/boards_util.js
ee/app/assets/javascripts/boards/epic_filtered_search.js
ee/app/assets/javascripts/boards/stores/actions.js
ee/app/assets/javascripts/epics_list/epics_list_bundle.js
ee/app/assets/javascripts/integrations/jira/issues_list/jira_issues_list_bundle.js
ee/app/assets/javascripts/issues_analytics/filtered_search_issues_analytics.js
ee/app/assets/javascripts/issues_analytics/index.js
ee/app/assets/javascripts/requirements/components/requirements_root.vue
ee/app/assets/javascripts/roadmap/roadmap_bundle.js
ee/app/assets/javascripts/test_case_list/components/test_case_list_root.vue
ee/app/assets/javascripts/test_case_list/test_case_list_bundle.js
spec/frontend/lib/utils/url_utility_spec.js

Screenshots (strongly suggested)

NA

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #328845 (closed)

Edited by Miguel Rincon

Merge request reports

Loading