Add confirmation modal to "Sync now" LDAP button
requested to merge 330902-ldap-synchronization-should-warn-before-it-kills-direct-member-list into master
📖 What does this MR do?
Related to #330902 (closed)
Adds a confirmation modal to the "Sync now" LDAP button to warn users that synchronizing LDAP removes direct members' access.
💻 Local testing
- Setup LDAP using the GDK LDAP guide
- Login as LDAP user
john
with passwordpassword
- Create a group
- Navigate to
Group
->Settings
->LDAP Synchronization
- Choose
LDAP Group cn
forSync method
- Choose
group1
from theLDAP Group cn
dropdown - Click
Add synchronization
- Navigate to
Overview
->Members
- Click
Sync now
button
📹 Videos
Before | After |
---|---|
Screen_Recording_2021-06-22_at_8.07.11_AM | Screen_Recording_2021-06-22_at_8.05.11_AM |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. - [-] This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman