Skip to content

Lower spec bar for number of sql queries

Gosia Ksionek requested to merge research_limiting_number_of_queries into master

What does this MR do?

In !63466 (merged) while fixing a bug I introduced new check, which resulted in more SQL queries in couple of places.

I decided to rearrange the code of the method to avoid not-necessary SQL queries. I think the lost of readability is minimal, but it lowers the pressure on db-level.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Gosia Ksionek

Merge request reports

Loading