Skip to content

Fix selecting scoped label in boards sidebar

Scott Stern requested to merge ss/fix-scoped-labels-select into master

What does this MR do?

When selecting a scoped label with the same scoped label key, we replace the old scoped label with the new scoped label

Follow-ups

  1. I dont think there should be any logic in the mutation, this logic should move to the actions
  2. Scoped labels is an ee feature and i think the actions need to be split as such when dealing with scoped labels
  3. We should add a mutation that updates the label because right now were mutating too much of the object

Repro

  1. Go to an issue board or epic board
  2. Create 2 scoped labels with the same scoped label key
  3. Apply the "other" scoped label

Resolves #334228 (closed)

Screenshots (strongly suggested)

2021-06-22_15.58.14

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ezekiel Kigbo

Merge request reports

Loading