Skip to content

Fix missing pagination headers for Branches endpoint

Vasilii Iakliushin requested to merge 331297_fix_pagination_headers_issue into master

What does this MR do?

Contributes to #331297 (closed)

Problem

Caching helper for Grape only stores and returns a response body. If endpoint sets additional headers, then there are missing in cached version.

Solution

Save headers in the cache and restore them if necessary

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports

Loading