Skip to content

Move "Confirm user" button into header of Admin area

Peter Hegman requested to merge peterhegman/admin-users-move-confirm-button into master

📖 What does this MR do?

In preparation for #332846 (closed) this MR moves the Confirm user button from a card to the header. It also changes the Impersonate button to the default button style and moves it to the right of the Edit button.

💻 Local testing

  1. Login as an Admin (root user in GDK)
  2. Navigate to Menu -> Admin -> Users and note the username of one of the users
  3. In your terminal in the gdk/gitlab directory run bin/rails console
  4. Run the following commands
    • user = User.find_by_username('<user name>')
    • user.confirmed_at = nil
    • user.save
  5. Navigate to Menu -> Admin -> Users and choose that user
  6. There should be a Confirm user button in the header

📷 Screenshots

View Before After
Unconfirmed user Screen_Shot_2021-06-29_at_9.47.36_AM Screen_Shot_2021-06-29_at_9.45.24_AM
Unconfirmed user modal Screen_Shot_2021-06-29_at_9.59.50_AM Screen_Shot_2021-06-29_at_9.45.38_AM
Confirmed user Screen_Shot_2021-06-29_at_9.47.08_AM Screen_Shot_2021-06-29_at_9.46.23_AM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading