Skip to content

Fix error when loading incident issue with alert

Tristan Read requested to merge tr-fix-incident-alert-error into master

What does this MR do?

An error appears when loading an incident that is linked to an alert.

The error is cause by an interaction with another graphql query on the page - see #326101 (closed) for details.

This MR:

  1. Ensures the error doesn't occur by adding an id field to the query.
  2. Adds a feature test to verify that the alert details and highlight bar load correctly.

issue here: #333043 (closed)

Screenshots (strongly suggested)

before after
Screenshot_2021-06-25_at_15.16.20 Screenshot_2021-06-25_at_15.16.46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports

Loading