Skip to content

Remove unnecessary reference to CAPTCHA

Chad Woolley requested to merge remove-captcha-refs-from-snippet-specs into master

What does this MR do?

Remove unnecessary reference to CAPTCHA from snippet frontend specs.

  • There's no longer any CAPTCHA-specific code at all in the component, so a CAPTCHA error is handled the same as any other error.
  • So, there is no reason to preserve the specific testing of UnsolvedCaptchaError handling here in the snippet edit component spec
  • See related slack thread

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related: convert-captcha-client-server-communication-to-use-headers-and-graphql-top-level-error-instead-of-fields-on-the-resource section on https://gitlab.com/groups/gitlab-org/-/epics/5527#convert-captcha-client-server-communication-to-use-headers-and-graphql-top-level-error-instead-of-fields-on-the-resource

Edited by Chad Woolley

Merge request reports

Loading