Skip to content

Set gitaly to use ssd storage class for new deployment

Albert requested to merge alberts-fix-gitaly-ssd-upgrade-review-app into master

What does this MR do?

Check if there is an existing review app deployment.

  1. If there is, do not set a ssd gitaly storage class
  2. If there is not, we can set a ssd gitaly storage class

For existing deployments that have not had an upgrade attempt to use ssd, this will allow them to be deployed. There would not be change to the existing stateful set.

For existing deployments that already have a failed upgrade attempt to use ssd, this may work, if helm sees that there is no difference in the stateful set. Otherwise, we'd still need to manually rollback helm to the state before it has ssd, or remove the deployment altogether.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Albert

Merge request reports

Loading