Move project runner controller to settings
What does this MR do?
Move project runner controller to settings
This refactor moves the runner controller to the setting folder to match more closely the menu structure to the project settings.
The motivation for this change is to make space for a future runner controller for projects that are not inside settings.
File locations
Old directory | New /settings dir |
---|---|
app/controllers/projects/runners_controller.rb |
app/controllers/projects/settings/runners_controller.rb |
ee/app/controllers/projects/runners_controller.rb |
ee/app/controllers/projects/settings/runners_controller.rb |
app/views/projects/runners/*.html.haml |
app/views/projects/settings/runners/*.html.haml |
Non-backward compatible paths
This change include changes in the Runners URLs: When visited from the project page, URLs have been updated.
Path | URL | New URL |
---|---|---|
Project > CI/CD Settings > Runner | http://gdk.test:3000/h5bp/html5-boilerplate/-/runners/14 | http://gdk.test:3000/h5bp/html5-boilerplate/-/settings/runners/14 |
Project > CI/CD Settings > Runner > Edit | http://gdk.test:3000/h5bp/html5-boilerplate/-/runners/14/edit | http://gdk.test:3000/h5bp/html5-boilerplate/-/settings/runners/14/edit |
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #19819 (closed)
Edited by Miguel Rincon