Skip to content

Log rejected commit SHAs along with push rule pattern

What does this MR do?

Resolves #4280 by inserting the commit SHA message content that failed a particular push rule into the resulting log message

Because the GitLab Shell log currently doesn't have any other referencing detail with other GitLab components it is very difficult to find out where and why exactly a certain push rule was broken.

Related, internal customer case & &3327.

Screenshots (strongly suggested)

… msg":"Commit message of 54fcc214 contains the forbidden pattern '…'"…

or

image

instead of only

… msg":"Commit message contains the forbidden pattern '…'"…

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Luke Duncalfe

Merge request reports

Loading