Make job_token_scope_enabled project setting false by default
What does this MR do?
Related to #333002 (closed)
Background
In !63446 (merged) and !62733 (merged) we introduced a project setting that enables the CI Job Token Scope feature for newly created projects.
The idea was to make this feature available by default for new projects while keeping it disabled for exiting projects due to backward compatibility problems. However, since implementing the CI Job Token Scope feature took slightly longer than expected we have some new projects created in the meantime with this feature enabled by default according to the project settings but the feature is still disabled via the feature flag. This means that while this setting is enabled by default it still behaves like it's disabled.
This is not a problem for the end-user today since the feature flag hasn't been enabled yet.
However we want to ensure that for now we don't enable this setting for new projects until the feature flag is enabled by default.
Solution
To bring the project setting in line with the feature flag status we are disabling the project setting and keep the default value to false.
In a follow-up MR, after the feature flag has been enabled by default, we will change the column default to true.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team