Skip to content

Convert minutes to seconds for escalation policies

Tristan Read requested to merge tr-fix-escalation-policy-parsing into master

What does this MR do?

There is a blocking bug in the escalation policies feature, where the UI minutes field is not converted to seconds when passing to the backend.

This change ensures that minutes are converted to seconds when saving escalation policies, and vice-versa when loading.

It achieves this with the following:

  • Adds a parser/serializer pair to the escalation policy utils.
  • Applies these for the get, create and update queries.
  • Renames seconds to minutes in all frontend usages, to match the form field.
  • Uses the bootstrap-vue number prop for this field.

Out of scope: Adding a new validation message as suggested in the issue.

Issue: #334732 (closed)

Screenshots (strongly suggested)

none

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports

Loading