Skip to content

Add ability to remove and disable terms and conditions

Max Woolf requested to merge disable-terms-and-conditions into master

What does this MR do?

  • Allows instance administrators to disable terms and conditions.
  • This is the first iteration of improving the terms and conditions functionality. groupcompliance may look at ways to improve this in the future.

Database Review

Up

== 20210708134446 RemoveNotNullConstraintFromTerms: migrating =================
-- change_column_null(:application_setting_terms, :terms, true)
   -> 0.0060s
== 20210708134446 RemoveNotNullConstraintFromTerms: migrated (0.0060s) ========

Down

== 20210708134446 RemoveNotNullConstraintFromTerms: reverting =================
-- change_column_null(:application_setting_terms, :terms, false)
   -> 0.0032s
== 20210708134446 RemoveNotNullConstraintFromTerms: reverted (0.0062s) ========

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #35923

Edited by Max Woolf

Merge request reports

Loading