Skip to content

Fixed diff file states getting incorrectly set

Phil Hughes requested to merge ph/fixDiffStateWithVirtualScroller into master

What does this MR do?

Fixes the diff file states getting used incorrectly. When the virtual scroller is enabled each diff file gets a re-used component so using the data property would mean that the state gets shared. With this IdState mixin, we can re-use the components and have their own state.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading