Refactor a SSOT for integration event descriptions
What does this MR do?
We were previously inconsistent about how we produced event descriptions for Integration
s.
Sometimes we referred to IntegrationsHelper
and sometimes through the model.
This change makes IntegrationsHelper
the single-source-of-truth for these strings.
It also adds the TeamCity integration
event description strings to our localisation files.
No tests have been added, but there are existing tests of ServiceEventEntity
and the API that
Screenshots (strongly suggested)
Previously the "TeamCity integration" form was not using the strings that were defined in Integrations::Teamcity.event_description
, and instead the form was displaying the "default" strings. Now, as all the logic has been moved to the helper as the SSOT, the special strings for Team City display instead of the default strings:
Editing the TeamCity integration (<project-full-path>/-/settings/services/teamcity/edit
):
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.