Check if default branch is already protected before creating
What does this MR do?
As a part of #329422 (closed): while creating security policy project, the default branch should be protected and push_access_levels
should have Gitlab::Access::NO_ACCESS
. So we create protected branch for the default branch with push_access_levels
.
Currently, BranchHooksService
also creates a protected branch with default_branch_protection
from the group that the project belongs to. This creates duplicate protected branches for the same default branch.
This change checks if the default branch is already protected before creating a protected branch. To avoid race condition from BranchHooksService
, we update the branch protection for default branch if it already exists while creating security policy project.
Screenshots (strongly suggested)
Before:
After:
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team