Skip to content

Remove unused HAML and CSS in members

Peter Hegman requested to merge peterhegman/remove-unused-members-haml-css into master

📖 What does this MR do?

Related to #324198 (closed)

Removes some HAML and CSS from the members section of the codebase. Because of an initiative to refactor the members view from HAML to Vue (&4233 (closed) and &4901 (closed)) this code is no longer needed.

💻 Local testing

Group members

  1. Create a group
  2. Navigate to Group information -> Members

Project members

  1. Create a project
  2. Navigate to Project information -> Members

Admin project overview

  1. Create a project
  2. Navigate to Menu -> Admin -> Projects -> the project you just created

Admin group overview

  1. Create a project
  2. Navigate to Menu -> Admin -> Groups -> the group you just created

📷 Screenshots

Expected to be the same

View Before After
Project members Screen_Shot_2021-06-30_at_5.01.09_PM Screen_Shot_2021-06-30_at_4.50.50_PM
Group members Screen_Shot_2021-06-30_at_5.00.13_PM Screen_Shot_2021-06-30_at_4.51.10_PM
Admin project overview Screen_Shot_2021-06-30_at_4.58.01_PM Screen_Shot_2021-06-30_at_4.51.39_PM
Admin group overview Screen_Shot_2021-06-30_at_4.58.27_PM Screen_Shot_2021-06-30_at_4.52.00_PM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading