Skip to content

Add missing `group` local assigns definition to HAML partials

📖 What does this MR do?

In !61180 (merged) I refactored some Cascading settings HAML partials. In !61418 (diffs) I documented these HAML partials. I noticed a typo where the group argument is required for these partials to work but it is not defined at the top of the HAML partials and it is not documented. We are, however, passing the group argument to the partials in the one place these are currently used: ee/app/views/groups/settings/_delayed_project_removal.html.haml#L9. Functionally this doesn't change anything as the partials worked before this change (and after 😆). This MR aims to improve discoverability and developer experience when using these partials.

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading