Skip to content

Deprecate project_avatar component

Tom Quirk requested to merge refactor-project-avatar into master

What does this MR do?

vue_shared/components/project_avatar/default.vue doesn't utilize GlAvatar, but it easily can! This MR:

  • Renames vue_shared/components/project_avatar/default.vue to vue_shared/components/project_avatar_deprecated/default.vue
  • Adds a new component vue_shared/components/project_avatar.vue which is a thin wrapper on GlAvatar
    • this includes a corresponding spec and Storybook story (project_avatar.stories.js)

After this MR, an epic will comprise of issues to migrate the deprecated instances with the new component: &6295 (closed)

No user-facing changes in this MR.

Resolves #335360 (closed)

Screenshots (strongly suggested)

Screenshot from Storybook:

Screen_Shot_2021-07-07_at_1.09.27_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading