Skip to content

Rearrange Merge Request version controls

Toon Claes requested to merge toon-move-latest-version-btn into master

What does this MR do?

The buttons at the top of the Merge Request diff view were a bit all over the place. This change attempts to place them more intuitively.

This includes:

  • On a single commit diff view, the commit hash is shown as a button between the "Prev" and "Next" buttons

  • When comparing versions, the commonly accepted 'comparison' icon is used between the two version dropdowns.

  • The "Show latest version" button was a bit out of place being between the diff stats and diff preferences. So it's moved to the left, right next to the commit or version buttons because they belong together.

Closes #330579

Screenshots (strongly suggested)

On single commit

Before

commit-before

After

commit-after

On older version in commit

Before

version-before

After

version-after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Toon Claes

Merge request reports

Loading