Skip to content

Update Pikaday colors for dark mode

Olena Horal-Koretska requested to merge 327430-pakaday-colors-dark-mode into master

What does this MR do?

This MR gitlab-ui!2317 (merged) adds Pikaday scss color variables overrides. This is done so that to support a dark mode where same scss variable has a different color value in dark and light mode. For some cases we need to add additional overrides where setting the color to the opposite shade in the palette does not work. These overrides are done in GitLab project rather than gitlab/ui as they are dark mode-specific (and dark mode is a product-specific feature rather than the library feature).

Screenshots (strongly suggested)

Before After
Screenshot_2021-07-01_at_14.20.35 2021-07-23_20.46.19

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327430 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading