Pass `caller_id` to `AuthorizedProjectUpdate::UserRefreshFromReplicaWorker`
What does this MR do?
We previously tried to pass the current meta.caller_id
attribute from the context of AuthorizedProjectUpdate::UserRefreshFromReplicaWorker
, down the stack to a newly enqueued AuthorizedProjectUpdate::UserRefreshWithLowUrgencyWorker
job over here, but it did not give us the intended result.
This was because as soon as we enter AuthorizedProjectUpdate::UserRefreshFromReplicaWorker
, caller_id
is set to its own class name, ie, AuthorizedProjectUpdate::UserRefreshFromReplicaWorker
in the context (source), so there is no way as of now to obtain the data of the original caller via Labkit over here.
The way to solve this now appears to be to pass the meta.caller_id
as meta.related_class
down the stack right from the point of origin of the first job, ie when AuthorizedProjectUpdate::UserRefreshFromReplicaWorker
is enqueued (which is at UserProjectAccessChangedService
), which is what this MR does.
Not adding a changelog because this behaviour is used at a place which is currently behind a feature flag (user_refresh_from_replica_worker_uses_replica_db
) and this flag is currently disabled in production.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team