Skip to content

Schedule requirements processing conditionally

Jan Provaznik requested to merge schedule_requirement_worker into master

What does this MR do?

Minimizes number of scheduled jobs for RequirementsManagement::ProcessRequirementsReportsWorker. If there are not any requirements in the project, we can skip completely processing of requirements in the job. This check is done also early in the process (https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/requirements_management/process_test_reports_service.rb#L16) but by checking directly in the finished worker we can avoid to schedule jobs completely - requirements are not yet used, so in 99% of cases, it will be skipped.

Related to #330676 (closed), but instead of moving this to replicas, this change should minimize dramatically number of jobs for this worker (see discussion in #330676 (comment 600380190))

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports

Loading