Fix race condition on container repository creation
What does this MR do?
There are some cases where a race condition can occur when a container repository is created during an image push.
There is a uniqueness constraint on the container repository project_id, name
. There is also rails validation on the same attributes. If a race condition occurs and the same repository is created twice using ContainerRepository.create_from_path!
, the second will fail with an ActiveRecord::RecordInvalid
or ActiveRecord::RecordNotUnique
error.
This MR adds a rescue block to ContainerRepository.create_from_path!
to check if the container repository already exists if one of these errors is thrown. If it exists, it is returned.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #215715 (closed)
Edited by Steve Abrams