Skip to content

Ensure any args are passed onto sidekiq

What does this MR do?

In gitlab-development-kit!2077 (merged) we explicitly set the --timeout for the rails-background-jobs GDK service to be half (10 secs) of the number of secs we wait from the runit side of things (20 secs). The idea here was to try to improve the reliability of the rails-background-jobs service which can at times enter a 'zombie' state and need to be forcibly killed, presumably because the default --timeout for sidekiq is 25 secs.

This MR ensures that any args passed to sidekiq (in this case, from GDK) are accepted when the time comes to actually execute. Without this change, In gitlab-development-kit!2077 (merged) has no impact.

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ash McKenzie

Merge request reports

Loading