Create SSoT for issuable sidebar toggling
What does this MR do?
Follow up from !60092 (merged) (#331778 (closed)), this MR cleans up the sidebar-toggling logic in issuable_sidebar_root.vue.
Requirement: we need to be able to toggle the sidebar from within the right-sidebar-items slot of issuable_sidebar_root.vue.
Previously, in derivates of the issuable_show_root component (which uses issuable_sidebar_root internally), we were manually dispatching click events on the sidebar toggle button. This has been refactored away in favor of a slot-based approach, where we pass a toggleSidebar method to the right-sidebar-items slot. Then, the slot content can emit an event to trigger this toggleSidebar method.
There are no user-facing changes with this MR (~"technical debt" only).
Screenshots (strongly suggested)
| Jira Issues sidebar | Test cases sidebar (includes demo of page refresh) |
|---|---|
| jira-sidebar-after | test-cae-sidebar-after |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #331778 (closed)