Skip to content

Allow Bulk Import to use relative GitLab URL

George Koltsov requested to merge georgekoltsov/bulk-import-relative-url into master

What does this MR do?

This MR does 2 things:

  1. Updates BulkImports::Clients::HTTP to not reconstruct user entered URL and instead use it as is in order to allow relative gitlab URL to be possible to use. E.g. http://mywebsite.example/gitlab
  2. Updates BulkImports::Clients::HTTP argument from uri to url for consistency. BulkImports::Clients::GraphQL client has url as parameter.

Mentions #330344 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by George Koltsov

Merge request reports

Loading