Avoid cache misses: Use Sidekiq.dump_json to serialize arguments
What does this MR do?
This will serialize the arguments into JSON, just like Sidekiq would
for calculating the #idempotency_string
and checking for duplicate
jobs.
This would be a more robust approach, because serialization of for example symbols would currently be different when serialized on the clientside versus after they have been loaded from redis.
It would not have affected anything on a running instance, because the key is already serialized into the job hash and checked like that in Sidekiq server.
Last step in gitlab-com/gl-infra/scalability#1090 (closed)
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Alex Kalderimis