Allow immediate deletion of projects
What does this MR do?
Allows users to immediately delete a project that is scheduled for delayed deletion. This allows users to re-use project paths immediately after deletion.
Related to #191367 (closed)
Other changes:
- I removed the warning styling on the "Restore project" section because that's not a destructive operation and also fixed some typos there.
- Improved the UI-text on the modal based on technical writer suggestions.
Screenshots or Screencasts (strongly suggested)
| Before | After |
|---|---|
 |
 |
I removed the danger styling of the "restore" section to differentiate it with the new "permanently delete" section. Restoring is not a destructive operation anyway.
Screen recording of the process from the initial delayed deletion to permanently deleting, and then creating a project with the same path.
Screen_Recording_2021-07-06_at_3.29.18_PM
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team