Split Builds Service to calculate minutes sync
What does this MR do?
This is part of pipeline cryptomining abuse measures. We want to cancel pipelines before deleting them because minutes are not accumulated on deleted jobs that continue to run. In order to cancel pipelines before deleting them and have minutes accumulate properly, we need to compute the minutes synchronously before the destroy to pass off to an async worker that can do the rest.
This MR breaks apart the UpdateBuildsMinute service into 2 so that part of the logic can be executed async. There are no changes to the existing behavior in this code. Also, this MR does not yet introduce the Ci::Minutes::UpdateMinutesByConsumptionWorker
that would move the logic of updating based on the consumption to async. That will come in another MR.
There is also a separate MR to introduce a feature flag:
Issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/331891
Screenshots or Screencasts (strongly suggested)
I tested that deleting a pipeline still works manually on my gdk and I tested minute accumulation by running a build to accumulate minutes after ensuring build.shared_runners_minutes_limit_enabled?
returns true and the monthly tracking is enabled locally via Feature.enable(:ci_minutes_monthly_tracking
.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team