Remove feature flag call that guarded nothing
What does this MR do?
It was discovered that this specific FF call guarded nothing (#29669 (comment 620049655)), and so we inadvertently released ability to set user timezone preference.
As development feature flags are supposed to be short-lived, let's keep what's already released, and keep moving forward.
Also, https://about.gitlab.com/handbook/values/#low-level-of-shame
Related issues: #29669 (closed), #15137 (closed)
/cc @ekigbo @peterhegman
Screenshots or Screencasts (strongly suggested)
Before vs after :
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
Edited by Thong Kuah