Log repository full_path in repository check error log
What does this MR do?
When logging the error message associated with a failed repository check, we do not currently make any attempt to include the repo path in the log message, making the repocheck.log pretty much useless. This MR adds the repo full_path to the logged message.
BEFORE:
E, [2021-07-08T04:16:35.628322 #3861] ERROR -- : Could not fsck repository: error: refs/heads/patch-1: invalid sha1 pointer 0000000000000000000000000000000000000000
AFTER:
E, [2021-07-08T04:45:54.965781 #10066] ERROR -- : root/test.wiki: Could not fsck repository: error: refs/patch-1: invalid sha1 pointer 0000000000000000000000000000000000000000
If #21547 (closed) is ever resolved, this fix will make the logged messages useful instead of maddening.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Diana Stanley