Use ProjectRecalculateWorker to refresh authorizations for Project-Group link create endpoints
What does this MR do?
Now that we are using AuthorizedProjectUpdate::ProjectRecalculateWorker
for refreshing project authorizations for project transfer, project-group share update, and project-group share destroy, it is OK for us to extend its usage to other areas as well.
One such area is project-group share create, which currently uses the specialized worker AuthorizedProjectUpdate::ProjectGroupLinkCreateWorker
, which can now be replaced with AuthorizedProjectUpdate::ProjectRecalculateWorker
which would do the same job.
(no changelog added as this is only a refactor)
Metrics to be used for comparison
Kibana Dashboard that can be used to compare the change.
Current 7 day metrics (which we should use for comparison, 7 days after this change is deployed)
- Performance of
ProjectGroupLinkCreateWorker
: Average of db_duration: 0.085 seconds - Safety-net jobs:
- Total safety-net jobs generated: 606770
- Safety-net jobs for project-group share create that made at least 1 write to db: 1030
- ie, % of safety-net jobs that wrote records to the database: 0.169%
We would expect both these numbers to improve after this change has been made.
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team