Skip to content

Use ProjectRecalculateWorker to refresh authorizations for Project-Group link create endpoints

What does this MR do?

Now that we are using AuthorizedProjectUpdate::ProjectRecalculateWorker for refreshing project authorizations for project transfer, project-group share update, and project-group share destroy, it is OK for us to extend its usage to other areas as well.

One such area is project-group share create, which currently uses the specialized worker AuthorizedProjectUpdate::ProjectGroupLinkCreateWorker , which can now be replaced with AuthorizedProjectUpdate::ProjectRecalculateWorker which would do the same job.

(no changelog added as this is only a refactor)

Metrics to be used for comparison

Kibana Dashboard that can be used to compare the change.

Current 7 day metrics (which we should use for comparison, 7 days after this change is deployed)

  • Performance of ProjectGroupLinkCreateWorker: Average of db_duration: 0.085 seconds
  • Safety-net jobs:
    • Total safety-net jobs generated: 606770
    • Safety-net jobs for project-group share create that made at least 1 write to db: 1030
    • ie, % of safety-net jobs that wrote records to the database: 0.169%

We would expect both these numbers to improve after this change has been made.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports

Loading