Reset job_token_scope_enabled setting to false
What does this MR do?
Related to #333002 (closed)
This MR is based on top of !64962 (merged) where we remove the default: true
value at the model-level for this setting. Given that the feature flag hasn't been fully enabled for this feature we need to start with the setting to be false for all projects.
In a follow-up MR, after we enabled the feature flag by default we will also change the default value to true
so that it will apply to all new projects.
Database migration
rails db:migrate:redo VERSION=20210628124505
== 20210628124505 ResetJobTokenScopeEnabled: reverting ========================
== 20210628124505 ResetJobTokenScopeEnabled: reverted (0.0000s) ===============
== 20210628124505 ResetJobTokenScopeEnabled: migrating ========================
-- remove_column(:project_ci_cd_settings, :job_token_scope_enabled)
-> 0.0027s
-- add_column(:project_ci_cd_settings, :job_token_scope_enabled, :boolean, {:default=>false, :null=>false})
-> 0.0044s
== 20210628124505 ResetJobTokenScopeEnabled: migrated (0.0200s) ===============
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino